Skip to content

feat(textarea): add small and large sizes for the ionic theme #29781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Aug 21, 2024
Merged

feat(textarea): add small and large sizes for the ionic theme #29781

merged 36 commits into from
Aug 21, 2024

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 19, 2024 •
edited
Loading

Issue number: internal

What is the current behavior?

Textarea only has the medium size for the ionic theme.

What is the new behavior?

  • Adds the small and large sizes for the ionic theme.
  • Adds tests for the sizes to the existing size test.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

brandyscarney and others added 19 commits August 16, 2024 13:02
@brandyscarney
feat(textarea): add default textarea styles
66f7231
@brandyscarney
fix(textarea): add proper structure, padding and spacing
98bdc88
@brandyscarney
style: lint
e55e4e2
@brandyscarney
feat(textarea): add size property with default set to medium
66f4adb
@brandyscarney
test(textarea): add test for sizes
25ae1a1
@brandyscarney
fix(textarea): move padding and spacing to all fills
ab46a02
@brandyscarney
chore(): add updated snapshots
91a5823
@brandyscarney
chore: build
ee00a2d
@brandyscarney
Merge branch 'next' into ROU-10916
2f7e2a7
@brandyscarney
docs(textarea): improve size description
1db5bbc
@brandyscarney
fix(textarea): separate common and native styles
e54fb4d
@Ionitron
chore(): add updated snapshots
74d9fb9
@brandyscarney
refactor(textarea): more cleanup between common and native
f4b7bc3
@brandyscarney
style: remove escapes
4947747
@brandyscarney
style: lint
9a46466
@brandyscarney
fix(textarea): use min height to autogrow
694242b
@brandyscarney
feat(textarea): add sm and lg sizes for ionic theme
2273735
@brandyscarney
test(textarea): update size test to include sm and lg
f852a85
@brandyscarney
chore(): add updated snapshots
630c12f
@vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 7:27pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 19, 2024
@brandyscarney brandyscarney changed the title Rou 10917 feat(textarea): add small and large sizes for the ionic theme Aug 19, 2024
@brandyscarney brandyscarney marked this pull request as ready for review August 19, 2024 20:55
@brandyscarney brandyscarney requested a review from a team as a code owner August 19, 2024 20:55
@brandyscarney brandyscarney requested review from BenOsodrac and removed request for a team August 19, 2024 20:55
thetaPC
thetaPC reviewed Aug 20, 2024
View reviewed changes
@brandyscarney brandyscarney requested a review from thetaPC August 21, 2024 18:08
Base automatically changed from ROU-10916 to next August 21, 2024 18:55
@brandyscarney brandyscarney mentioned this pull request Aug 21, 2024
Merged
2 tasks
thetaPC
thetaPC approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit e539620 into next Aug 21, 2024
@brandyscarney brandyscarney deleted the ROU-10917 branch August 21, 2024 20:15
joselrio pushed a commit that referenced this pull request Aug 22, 2024
@brandyscarney @joselrio
feat(textarea): add small and large sizes for the ionic theme (#29781)
bdf5881 
- Adds the `small` and `large` sizes for the `ionic` theme
- Adds tests for the sizes to the existing `size` test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brandyscarney @thetaPC @BenOsodrac @Ionitron