Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Aug 27, 2024

Issue number: internal


What is the current behavior?

ionic theme: ion-radio-group does not match the designs when there are multiple radios and not inside a ion-list.

What is the new behavior?

  • Add styles to ion-radio when not inside a list.
  • Added tests to check for radio groups within a list and without being in a list.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview (basic)
Preview (list)

@vercel
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 9:41pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 27, 2024
@thetaPC thetaPC changed the title feat(radio): add ionic styles for radio group feat(radio): add ionic styles with radio group Aug 27, 2024
@thetaPC thetaPC marked this pull request as ready for review August 27, 2024 22:26
@thetaPC thetaPC requested a review from a team as a code owner August 27, 2024 22:26
@thetaPC thetaPC requested review from BenOsodrac and removed request for a team August 27, 2024 22:26
@thetaPC thetaPC merged commit aa11b93 into ROU-11015 Aug 29, 2024
@thetaPC thetaPC deleted the ROU-11014 branch August 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants