Skip to content

fix(modal): fix enter animation when the initial breakpoint value is less than the backdrop breakpoint #29955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix(modal): fix enter animation when the initial breakpoint value is less than the backdrop breakpoint #29955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3e9826
Fixing enter animation when backdropBreakpoint is greater than curren…
OS-pedrolourenco Oct 21, 2024
7d20b5d
CR
OS-pedrolourenco Oct 22, 2024
e256b42
Merge branch 'next' into ROU-11247-v2
OS-pedrolourenco Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions core/src/components/modal/animations/sheet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@ export const createSheetEnterAnimation = (opts: ModalAnimationOptions) => {
* current breakpoint, then the backdrop should be fading in.
*/
const shouldShowBackdrop = backdropBreakpoint === undefined || backdropBreakpoint < currentBreakpoint!;
const initialBackdrop = shouldShowBackdrop
? `calc(var(--backdrop-opacity) * ${staticBackdropOpacity ? 1 : currentBreakpoint!})`
: '0';
let initialBackdrop = '0';
if (staticBackdropOpacity) {
initialBackdrop = 'calc(var(--backdrop-opacity)';
} else if (shouldShowBackdrop) {
initialBackdrop = `calc(var(--backdrop-opacity) * ${currentBreakpoint!})`;
}

const backdropAnimation = createAnimation('backdropAnimation').fromTo('opacity', 0, initialBackdrop);

Expand Down
2 changes: 2 additions & 0 deletions core/src/components/modal/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,8 @@ interface ModalOverlayOptions {
/**
* The point after which the backdrop will begin
* to fade in when using a sheet modal.
* This option is ignored for the ionic theme
* due to the option below.
*/
backdropBreakpoint: number;
/**
Expand Down
Loading