refactor(searchbar): update according to design #30245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested changes
Mar 13, 2025
Comment on lines
22
to
23
| --leading-icon-padding: #{calc(globals.$ion-scale-400 + globals.$ion-space-200)}; | ||
| --clear-button-padding: #{calc(globals.$ion-scale-400 + globals.$ion-space-200)}; |
There was a problem hiding this comment.
Why were these new variables added? We need to be careful when adding new ones because it introduces them to the public so we try to make sure that they're necessary.
If they're to make it easier to keep track of then it might be best to make Sass variables.
There was a problem hiding this comment.
These variables were created with the purpose of making the searchbar's start and end paddings be dynamic according to whether it is rendering leading and/or trailing icons. That being said, I don't see a reason why they have to be CSS variables instead of SCSS variables so I'll make that change 👍🏼
OS-pedrolourenco
changed the title
thetaPC
requested changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The searchbar component does not currently match our UX designs for the ionic theme.
What is the new behavior?
Updated the searchbar so that it does:
Does this introduce a breaking change?
Other information