Skip to content

Conversation

@joselrio
Copy link
Contributor

@joselrio joselrio commented Mar 13, 2025

Issue number: internal

What is the current behavior?

  • tab-button with badge only supports status badges (small circle with specific color), missing cases with text or icon.

What is the new behavior?

  • Added css on tab-button to support new badge hint functionalities such text and icon
  • Added css on badge to support the existence of a icon inside it
  • Added support on ionic theme for different position (top and button)
  • Added badge test case for this use case
  • There's no figma for md/iOS implementation, so just added for now a best effort on how it looks.

Theme md:
md

Theme iOS:
ios

Theme ionic:
ionic

Notes:

  • All the styles added are based on the [vertical] attribute in order to prevent breaking changes and only affect the badge hint with the new features implemented.
  • Also top and bottom position under the context of md/iOS themes are not exactly the same as ionic theme due the usage of an overflow:hidden; attribute at the .button-native context. This overflow:hidden; attribute has been overwritten to overflow:visible; for ionic theme.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sample

@joselrio joselrio requested a review from a team as a code owner March 13, 2025 15:17
@joselrio joselrio requested a review from ShaneK March 13, 2025 15:17
@vercel
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 5:34pm

@joselrio joselrio changed the title feat(tab-button): support new badge hint feature feat(tab-button): support new badge hint features Mar 13, 2025
@github-actions github-actions bot added the package: core @ionic/core package label Mar 13, 2025
@joselrio joselrio requested a review from thetaPC March 14, 2025 16:23
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code to accomplish this is already set with MD. We don't need to make alterations to badge or add variables. We should follow the consistency of how MD handles badges within tab buttons.

@joselrio joselrio requested a review from thetaPC March 19, 2025 21:00
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes were made. Please push your changes.

@joselrio joselrio requested a review from thetaPC March 19, 2025 22:35
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joselrio joselrio merged commit c5fb051 into next Mar 21, 2025
48 checks passed
@joselrio joselrio deleted the ROU-11666 branch March 21, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants