-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(tab-button): support new badge hint features #30246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code to accomplish this is already set with MD. We don't need to make alterations to badge or add variables. We should follow the consistency of how MD handles badges within tab buttons.
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes were made. Please push your changes.
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue number: internal
What is the current behavior?
What is the new behavior?
Theme md:

Theme iOS:

Theme ionic:

Notes:
overflow:hidden;attribute at the.button-nativecontext. Thisoverflow:hidden;attribute has been overwritten tooverflow:visible;for ionic theme.Does this introduce a breaking change?
Other information
Sample