Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 19, 2025

Issue number: internal


What is the new behavior?

  • Adds the common stylesheet for the shared styles
  • Adds design for helper and error text to the checkbox for the ionic theme.
  • Updates tests to add screenshots for ionic theme

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel
Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:11pm

max-width: calc(100% / 0.75);
}

// TODO(ROU-10796): uncomment this when the scss compilation issue is fixed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this should close ROU-10796

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how ios and md look so I assume we want the same here

@brandyscarney brandyscarney changed the base branch from FW-6389 to next March 20, 2025 15:04
@brandyscarney brandyscarney marked this pull request as ready for review March 20, 2025 20:00
@brandyscarney brandyscarney requested a review from a team as a code owner March 20, 2025 20:00
@brandyscarney brandyscarney requested a review from gnbm March 20, 2025 20:00
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit f0516e6 into next Mar 25, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6389-checkbox branch March 25, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants