Skip to content

fix(button): ionic theme sizes #30405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 14, 2025
Merged

fix(button): ionic theme sizes #30405

merged 17 commits into from
May 14, 2025

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented May 12, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Adjusted ion-button sizes on Ionic theme to match Figma UI. Now figma's small | medium | large match ionic's small | default | large.
  • Removed xsmall and xlarge sizes, as UX rolled back the decision to have them.
  • Removed xsmall and xlarge tests and their usages.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels May 12, 2025
@vercel
Copy link

vercel bot commented May 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:07am

@BenOsodrac BenOsodrac changed the title fix(button): fix ionic button sizes fix(button): ionic button sizes May 13, 2025
@BenOsodrac BenOsodrac changed the title fix(button): ionic button sizes fix(button): ionic theme button sizes May 13, 2025
@BenOsodrac BenOsodrac changed the title fix(button): ionic theme button sizes fix(button): ionic theme sizes May 13, 2025
@BenOsodrac BenOsodrac marked this pull request as ready for review May 13, 2025 11:51
@BenOsodrac BenOsodrac requested a review from a team as a code owner May 13, 2025 11:51
@BenOsodrac BenOsodrac requested review from brandyscarney and christian-bromann and removed request for christian-bromann May 13, 2025 11:51
brandyscarney
brandyscarney requested changes May 13, 2025
View reviewed changes
@BenOsodrac @brandyscarney
Update core/src/components/button/button.tsx
46baaa6 
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
@BenOsodrac BenOsodrac requested a review from brandyscarney May 13, 2025 17:07
brandyscarney
brandyscarney reviewed May 13, 2025
View reviewed changes
BenOsodrac and others added 2 commits May 14, 2025 10:42
@BenOsodrac @brandyscarney
Update core/src/components/button/button.ionic.scss
7796b18 
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
@BenOsodrac
remove xlarge spinner tests
8d3a531
@BenOsodrac BenOsodrac requested a review from brandyscarney May 14, 2025 10:29
brandyscarney
brandyscarney approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@BenOsodrac BenOsodrac merged commit 6a1382f into next May 14, 2025
48 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11903 branch May 14, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BenOsodrac @brandyscarney @Ionitron