feat(themes): allow mode specific custom theme overrides with modular themes #30657
+148
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
changed the title
brandyscarney
changed the title
brandyscarney
changed the title
ShaneK
approved these changes
Aug 29, 2025
brandyscarney
added a commit
that referenced
this pull request
Sep 25, 2025
… themes (#30657) Issue number: internal --------- ## What is the current behavior? A `customTheme` object can not change based on the mode. ## What is the new behavior? Adds top level `ios` and `md` property checks to flatten with the `customTheme` object based on the mode. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Requires additional changes in order to test. --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
A
customThemeobject can not change based on the mode.What is the new behavior?
Adds top level
iosandmdproperty checks to flatten with thecustomThemeobject based on the mode.Does this introduce a breaking change?
Other information
Requires additional changes in order to test.