fix(button): fix colors and ripple-effect

core/src/components/button/button.ionic.scss

@@ -43,8 +43,8 @@
 // --------------------------------------------------
 
 :host(.button-solid) {
-  --background-activated: #{globals.ion-color(primary, shade)};
-  --background-hover: #{globals.ion-color(primary, shade)};
+  --background-activated: #{globals.$ion-bg-primary-base-press};
+  --background-hover: #{globals.$ion-bg-primary-base-press};
   --background-focused: transparent;
   --background-hover-opacity: 1;
   --background: #{globals.ion-color(primary, base)};
@@ -53,45 +53,61 @@
   --ripple-color: var(--background-activated);
 }
 
+:host(.button-solid.ion-color) {
+  --background-activated: #{globals.current-color(shade)};
+  --background-hover: #{globals.current-color(shade)};
+  --background: #{globals.current-color(base)};
+  --color: #{globals.current-color(contrast)};
+}
+
 // Outline Button
 // --------------------------------------------------
 
 :host(.button-outline) {
   --border-width: #{globals.$ion-border-size-025};
   --border-style: #{globals.$ion-border-style-solid};
-  --background-activated: #{globals.$ion-bg-neutral-subtlest-press};
+  --background-activated: #{globals.$ion-bg-primary-subtle-press};
   --background-focused: transparent;
-  --background-hover: #{globals.$ion-bg-neutral-subtlest-press};
+  --background-hover: #{globals.$ion-bg-primary-subtle-press};
   --background-hover-opacity: 1;
   --border-color: #{globals.ion-color(primary, base)};
   --color: #{globals.ion-color(primary, base)};
   --ripple-opacity: var(--background-activated-opacity, 1);
   --ripple-color: var(--background-activated);
 }
 
+:host(.button-outline.ion-color) {
+  --background-activated: #{globals.current-color(shade, $subtle: true)};
+  --background-hover: #{globals.current-color(shade, $subtle: true)};
+  --border-color: #{globals.current-color(base)};
+  --color: #{globals.current-color(base)};
+}
+
+// Warning Outline Button - use foreground color for text and border
+:host(.button-outline.ion-color-warning) .button-native {
+  --ion-color-base: #{globals.ion-color(warning, foreground)};
+}
+
 // Clear Button
 // --------------------------------------------------
 
 :host(.button-clear) {
-  --background-activated: #{globals.$ion-bg-neutral-subtlest-press};
+  --background-activated: #{globals.$ion-bg-primary-subtle-press};
   --background-focused: transparent;
-  --background-hover: #{globals.$ion-bg-neutral-subtlest-press};
+  --background-hover: #{globals.$ion-bg-primary-subtle-press};
   --background-hover-opacity: 1;
   --color: #{globals.ion-color(primary, foreground)};
   --ripple-opacity: var(--background-activated-opacity, 1);
   --ripple-color: var(--background-activated);
 }
 
-// Ripple Effect
-// -------------------------------------------------------------------------------
+:host(.button-clear.ion-color) {
+  --background-activated: #{globals.current-color(shade, $subtle: true)};
+  --background-hover: #{globals.current-color(shade, $subtle: true)};
 
-:host(.button-solid.ion-color) ion-ripple-effect {
-  color: globals.current-color(shade);
-}
-
-:host(.button-outline.ion-color) ion-ripple-effect,
-:host(.button-clear.ion-color) ion-ripple-effect {
-  color: globals.$ion-primitives-neutral-200;
+  .button-native {
+    --ion-color-base: #{globals.current-color(foreground)};
+  }
 }
 
 // Button Sizes

core/src/components/button/test/theme-ionic/index.html

@@ -56,7 +56,8 @@ <h4>Preview options</h4>
             <ion-select-option value="primary">Primary</ion-select-option>
             <ion-select-option value="success">Success</ion-select-option>
             <ion-select-option value="warning">Warning</ion-select-option>
-            <ion-select-option value="neutral">Neutral</ion-select-option>
+            <ion-select-option value="medium">Medium</ion-select-option>
+            <ion-select-option value="danger">Danger</ion-select-option>
           </ion-select>
         </p>