Skip to content

fix(toggle): remove full width rule from ionic theme #30809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoaoFerreira-FrontEnd merged 2 commits into from
Nov 25, 2025
Merged

fix(toggle): remove full width rule from ionic theme #30809

JoaoFerreira-FrontEnd merged 2 commits into from
Nov 25, 2025

Conversation

@JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Nov 25, 2025 •
edited
Loading

Issue number: internal

What is the current behavior?

  • even when the justify was undefined, the toggle was full-width:

What is the new behavior?

  • It's possible to have an inline input;
  • If a full width is needed, use the justify prop;

Does this introduce a breaking change?

  • Yes
  • No

Other information

basic
item
label

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner November 25, 2025 15:49
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the type: bug a confirmed bug report label Nov 25, 2025
@vercel
Copy link

vercel bot commented Nov 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Nov 25, 2025 4:05pm

@github-actions github-actions bot added the package: core @ionic/core package label Nov 25, 2025
@brandyscarney brandyscarney changed the title fix(toggle): remove full width rule fix(toggle): remove full width rule from ionic theme Nov 25, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 0985187 into next Nov 25, 2025
51 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-12327 branch November 25, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@BenOsodrac BenOsodrac Awaiting requested review from BenOsodrac BenOsodrac is a code owner automatically assigned from ionic-team/framework

Assignees

No one assigned

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoaoFerreira-FrontEnd @brandyscarney @Ionitron