-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(modal): allow interaction with parent content through sheet modals in child routes #30839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e aren't allowing clicks through the background
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dc6d1ca to
7a814e9
Compare
7a814e9 to
f776b49
Compare
f776b49 to
34d3993
Compare
34d3993 to
3050ddf
Compare
…s showBackdrop=false in child routes
3050ddf to
cc6727a
Compare
a723344 to
ef60cf1
Compare
b662863 to
4454872
Compare
63d3985 to
38743ff
Compare
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing is that I couldn't get the Angular page to interact for me. Please let me know if I just missed something.
.../angular/test/base/src/app/standalone/modal-child-route/modal-child-route-child.component.ts
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/app-standalone/app.routes.ts
Show resolved
Hide resolved
packages/react/test/base/tests/e2e/specs/overlay-components/IonModalSheetChildRoute.cy.ts
Show resolved
Hide resolved
…ages, caching page parent to prevent excessive searching
4437209 to
6780fad
Compare
brandyscarney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking requests. Looks good!
Issue number: resolves #30700
What is the current behavior?
When a sheet modal with showBackdrop=false is rendered in a child route (nested ion-router-outlet), the parent content becomes non-interactive. Clicks on buttons or other interactive elements in the parent component are blocked, even though showBackdrop=false should allow background interaction.
Two separate issues contributed to this bug:
backdropBreakpoint: TheshouldLockRootlogic inoverlays.tsdidn't account forbackdropBreakpoint. Modals withbackdropBreakpoint > 0were still locking the root witharia-hidden, even though developers expect background interaction when the modal is below the backdrop breakpoint.ion-page) and its parention-router-outletremain in the DOM withposition: absolutecovering the viewport. Even after the modal is moved toion-appand haspointer-events: none, these wrapper elements block clicks to the parent page's content.This issue stems from #30563, which added root-locking behavior that didn't account for modals that allow background interaction. A partial fix in #30689 partially addressed
showBackdrop=falseandfocusTrap=false, but missedbackdropBreakpoint.What is the new behavior?
Sheet modals with showBackdrop=false or focusTrap=false now correctly allow interaction with parent content when the modal is in a child route.
Improvements:
Does this introduce a breaking change?
Other information
Dev build: