Skip to content

feat(textarea): adjusting min-height of the textarea for ionic theme#30957

Open
rugoncalves wants to merge 48 commits intonextfrom
ROU-12443-v4
Open

feat(textarea): adjusting min-height of the textarea for ionic theme#30957
rugoncalves wants to merge 48 commits intonextfrom
ROU-12443-v4

Conversation

@rugoncalves
Copy link

@rugoncalves rugoncalves commented Feb 16, 2026

Issue number: resolves internal


This pull request introduces new tests and refactors the styling for the ion-textarea component, especially for the ionictheme.

What is the current behavior?

  • Ionic theme specifics:
    • Some paddings and margins were applied in different place;

What is the new behavior?

  • The ionic theme has the following changes:
    • .textarea-size-* classes stopped forcing the min-height;
  • Added an end-to-end test file textarea.e2e.ts to verify that the rows attribute is respected across different values, sizes, and with auto-grow enabled.
  • Introduced a new HTML test page (index.html) for visual/manual testing of ion-textarea with different rows and size combinations, and with auto-grow enabled.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Original PR

Copilot AI review requested due to automatic review settings February 16, 2026 17:58
@rugoncalves rugoncalves requested a review from a team as a code owner February 16, 2026 17:58
@rugoncalves rugoncalves requested a review from ShaneK February 16, 2026 17:58
@vercel
Copy link

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Feb 18, 2026 9:33pm

Request Review

@github-actions github-actions bot added the package: core @ionic/core package label Feb 16, 2026
@rugoncalves rugoncalves marked this pull request as draft February 16, 2026 17:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where textareas with the rows attribute set to 1 (or other values) would not properly respect the row count due to forced min-height values in the Ionic theme. The fix adjusts padding placement and removes fixed min-height constraints when the rows attribute is present.

Changes:

  • Removed hardcoded min-height values from .textarea-size-* classes in the Ionic theme
  • Added min-height: auto override for textareas with the rows attribute
  • Moved padding from .textarea-wrapper-inner to .native-textarea when rows is set (for proper scrolling behavior)
  • Added comprehensive e2e tests for the rows functionality

Reviewed changes

Copilot reviewed 4 out of 91 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
textarea.ionic.scss Removed min-height from size classes; added padding redistribution for rows attribute
textarea.common.scss Added min-height: auto override for textareas with rows attribute
test/rows/textarea.e2e.ts New comprehensive test suite for rows functionality
test/rows/index.html New manual testing page for rows feature
Various snapshot files Updated visual regression test snapshots

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rugoncalves rugoncalves marked this pull request as ready for review February 16, 2026 18:04
@rugoncalves rugoncalves marked this pull request as draft February 16, 2026 18:05
@rugoncalves rugoncalves marked this pull request as ready for review February 16, 2026 18:33
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments