feat(popover): add default styles for ionic theme#31028
Merged
os-davidlourenco merged 7 commits intonextfrom Mar 24, 2026
Merged
feat(popover): add default styles for ionic theme#31028os-davidlourenco merged 7 commits intonextfrom
os-davidlourenco merged 7 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-davidlourenco
changed the title
os-davidlourenco
force-pushed
the
ROU-12661
branch
from
c5c75b1 to
572618f
Compare
os-davidlourenco
force-pushed
the
ROU-12661
branch
from
572618f to
528093d
Compare
os-davidlourenco
force-pushed
the
ROU-12661
branch
from
607fd23 to
0daa416
Compare
thetaPC
approved these changes
Mar 23, 2026
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, with minor requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Using the Ionic theme, the popover is not visible on iOS devices.
What is the new behavior?
A new theme is applied for the popover for both Android and iOS devices, allowing the popover to be made visible.
Does this introduce a breaking change?
Other information
This PR creates a new ionic theme for popover.
The md theme was used as template since we didn't wan't to have breaking changes