chore(vercel): add react-router preview build and fix dir-index navigation#31105
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
thetaPC
approved these changes
Apr 30, 2026
Comment on lines
+276
to
+277
| # The react-router test apps require --legacy-peer-deps (mixed react versions | ||
| # across @ionic/react peer ranges). |
Contributor
There was a problem hiding this comment.
Assuming there's a ticket to remove the --legacy-peer-deps, let's add the TODO here.
Member
Author
There was a problem hiding this comment.
There's not, and I don't really want to. Any time we upgrade react router we'd have to add it back and there's no harm in having it at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, reviewing react router based PRs isn't possible using the vercel preview link
What is the new behavior?
This PR adds support for the preview link to support react router 6 and tries to fix some weird edge cases where navigating to a route would sometimes not show the tests in that route
Does this introduce a breaking change?
Other information
The new React Router preview app shares the React package gate (
REACT_PKG_OK) because@ionic/react-routeris built insidebuild_react_pkgs(). Test app builds run in parallel under that gate, thenwaitreports per-app failures.Preview URLs (once Vercel builds this branch):
basic/,buffer/,determinate/should now land on the test page instead of the root landing)