Conversation
…uttons (#31109) Issue number: resolves #31090 --------- ## What is the current behavior? Buttons configured with `role: "selected"` no longer receive the `action-sheet-selected` CSS class. Userland styling that targets `.action-sheet-selected` (the documented hook for marking the active option — bold text, custom checkmarks, etc.) silently stopped working as of `8.7.12`. This regressed in #30769 (`fix(select, action-sheet): use radio role for options`). The new render path computes the button's class as: ```tsx class={{ ...buttonClass(b), 'action-sheet-selected': isActiveRadio, }} ``` `buttonClass(b)` already emits `'action-sheet-selected': true` for `role: "selected"` (via `[action-sheet-${button.role}]]: button.role !== undefined`), but the second key with the same name overrides it. For any non-radio button `isActiveRadio` is `false`, so the class is dropped from the rendered `<button>`. ### Repro ```html <ion-action-sheet id="sheet" header="Choose"></ion-action-sheet> <script type="module"> await customElements.whenDefined("ion-action-sheet"); const sheet = document.getElementById("sheet"); sheet.buttons = [ { text: "Option A" }, { text: "Option B", role: "selected" }, { text: "Cancel", role: "cancel" }, ]; await sheet.present(); </script> ``` In `8.7.11` the Option B button gets `action-sheet-selected`. In `8.7.12+` it does not. ## What is the new behavior? - Only override `action-sheet-selected` based on `isActiveRadio` when the button actually participates in the radio group (`b.htmlAttributes?.role === 'radio'`). For non-radio buttons, the class map produced by `buttonClass(b)` is left untouched, so `role: "selected"` keeps emitting `action-sheet-selected` exactly as it has since the component was introduced. - Adds a spec-test regression covering the `role: "selected"` case. This preserves the new radio-group behavior introduced in #30769 (when the button is a radio, `action-sheet-selected` follows `activeRadioId`) and restores the documented public API. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information - The minified output for the lazy + custom-elements bundles becomes `Object.assign(Object.assign({}, buttonClass(b)), isRadio && {"action-sheet-selected": isActiveRadio})`. When `isRadio` is `false`, `Object.assign(target, false)` is a no-op and the class set by `buttonClass(b)` is preserved. - Verified in a real consumer app on 8.8.4: with this patch built and installed locally, `role: "selected"` once again renders `class="... action-sheet-selected ..."` on the `<button>`. Made with [Cursor](https://cursor.com)
…31112) Issue number: resolves internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? - When the first segment is disabled and the last item is selected, if the user swipes the `segment-view`, the first `segment-button` gets checked even if it is disabled, and the view is presenting other `segment-view`. ## What is the new behavior? - A validation was added to ensure that the `segment-button` can only be checked if it is not disabled ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
v8.8.6
# Conflicts: # packages/react-router/package-lock.json # packages/react/package-lock.json # packages/react/package.json # packages/vue/package-lock.json # packages/vue/package.json
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync major-9.0 with main.