Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
In certain circumstances,
ion-selectemitsionChangeevery time the overlay is confirmed, even when the user picks the option that was already selected. Thepopoverandmodalinterfaces don't have this issue because they delegate selection toion-radio-group/ion-checkbox, which already de-dupe. The mismatch is inselect.tsx: the alert OK handler and each action-sheet button handler callsetValue()unconditionally, andsetValue()always emits.This contradicts the documented behavior ("Emitted when the value has changed") and is inconsistent with
ion-input,ion-textarea, and the other select interfaces.What is the new behavior?
setValue()now compares the incoming value against the current value and early-returns when they match, soionChangeonly fires on an actual change. The comparison honorscompareWithfor object values and treatsmultiplearrays as equal when they contain the same elements regardless of order. Behavior across all four interfaces is now consistent.Does this introduce a breaking change?
Apps that relied on
ionChangefiring on every alert/action-sheet confirmation, even without a value change, will need to listen forionDismiss(or the alert/action-sheet's own dismiss event) instead. This aligns alert/action-sheet with howpopoverandmodalalready behave, and with how every other Ionic form control handlesionChange.Other information
Preview pages (open the alert or action-sheet, click OK or tap the already-selected option, watch the console):
This goes along with the breaking change documentation in ionic docs, here: