Skip to content

test(many): update controller tests to use correct import path#31178

Merged
brandyscarney merged 1 commit into
mainfrom
test-vercel-controllers
May 28, 2026
Merged

test(many): update controller tests to use correct import path#31178
brandyscarney merged 1 commit into
mainfrom
test-vercel-controllers

Conversation

@brandyscarney
Copy link
Copy Markdown
Member

Many of the controller tests are using the wrong path to import the overlay controllers. This results in those tests not working in Vercel.

To reproduce the issue:

  1. Open the Action Sheet (main) preview
  2. Attempt to open any Action Sheet
  3. See the Action Sheet does not open and there is the following console error: ReferenceError: actionSheetController is not defined

To see it working:

  1. Open the Action Sheet (branch) preview
  2. Attempt to open any Action Sheet
  3. See the Action Sheet opens without any errors

This should be able to reproduce on any of the updated tests.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment May 28, 2026 6:30pm

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label May 28, 2026
@brandyscarney brandyscarney marked this pull request as ready for review May 28, 2026 18:43
@brandyscarney brandyscarney requested a review from a team as a code owner May 28, 2026 18:43
@brandyscarney brandyscarney requested a review from ShaneK May 28, 2026 18:43
Copy link
Copy Markdown
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work 🚀

@brandyscarney brandyscarney added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit 23f6c20 May 28, 2026
51 checks passed
@brandyscarney brandyscarney deleted the test-vercel-controllers branch May 28, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants