Fix stacked select margins and padding.#5860
Closed
nikmartin wants to merge 4306 commits intoionic-team:masterfrom
Closed
Fix stacked select margins and padding.#5860nikmartin wants to merge 4306 commits intoionic-team:masterfrom
nikmartin wants to merge 4306 commits intoionic-team:masterfrom
Conversation
Update documentation
fix(): add default link color
fix(scroll): prevent 'cannot read from undefined' exception
Fixes ionic-team#4070 because Windows Phone reports itself as being "Mozilla/5.…
Added two more choices of column size: 40% and 60%
Access popup scope in the tap event handlers
Add missing "if"
extension to support multiple selection
don't throw exceptions if the view is destroyed before the view is resized
…ewheel Added mousewheel support for touch devices
Fix `e.detail.keyboardHeight` undefined error in keyboardAttach directive
Using parseFloat() to yield more precise pixel calculation.
Make ionRefresher promise-friendly
Add Subfooter with tabs support
exposeAsideWhen directive bug fix
(/^(select|option)$/i).test(e.target.tagName) exported in separate function
Folder name is different in doc from origin.
docs: js/angular-ui/ directory reference
Update scrollDelegate.js
…rom calling update())
fix(nullRef): nullify reference to the destroyed slider
docs(): close ion-input tag correctly
This reverts commit 56bb89e.
docs(): correct break tag in events.js
make padding of stacked select match stacked input
Author
|
The padding appears to be slightly platform dependent. In a browser, it lines up, but on mobile android, the select is slightly indented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The alignment of stacked labels on selects is inconsistent with the selected value and of other stacked labels. The padding of stacked select is also inconsistent with stacked inputs. This fixes both of these.
With -3px margin and no padding:
without -3px margin and matching padding:
Changes proposed in this pull request:
.item-select.item-stacked-label selectmatch.item-stacked-label inputIonic Version: 1.x
Fixes: #