Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

  • Installs Playwright
  • Installs serve dev dependency
  • Updated Stencil

I opted to use the same settings as Ionic Framework since those seem to work well.

@liamdebeasi liamdebeasi marked this pull request as ready for review September 30, 2022 19:22
@sean-perkins
Copy link
Contributor

Is this intending to be the comprehensive integration for Playwright or the first PR with others to follow?

With using Stencil, we are still going to need something like: https://github.com/sean-perkins/stencil-playwright/blob/main/packages/stencil-playwright/src/playwright-page.ts#L31-L41 in a custom fixture and overriding the goto implementation: https://github.com/sean-perkins/stencil-playwright/blob/ac83e9c862c8b2f399e21d073cb65c6eec16c0b6/packages/stencil-playwright/src/page/utils/go-to.ts#L12

@liamdebeasi
Copy link
Contributor Author

This will be the first of multiple PRs

@liamdebeasi liamdebeasi merged commit fc05cf0 into playwright Sep 30, 2022
@liamdebeasi liamdebeasi deleted the p-install branch September 30, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants