Skip to content

test(icon): add visual regression test #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 30, 2022
Merged

test(icon): add visual regression test #1123

merged 14 commits into from
Sep 30, 2022

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 30, 2022

This PR does a few things:

  1. Adds a screenshot test for the icon component. Right now we are taking a screenshot of index.html
  2. Adds infrastructure adapted from Ionic Framework so that Playwright waits for Stencil to be ready before proceeding with tests. (I only added what we need right now)
  3. Updates the tsconfig file so we can use alias imports for grabbing test utils

Note: This does not include an CI infrastructure.

@liamdebeasi liamdebeasi marked this pull request as ready for review September 30, 2022 20:21
@liamdebeasi liamdebeasi merged commit 674eda4 into playwright Sep 30, 2022
@liamdebeasi liamdebeasi mentioned this pull request Sep 30, 2022
Merged
@liamdebeasi liamdebeasi deleted the p-tests branch September 30, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sean-perkins sean-perkins sean-perkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamdebeasi @sean-perkins