Skip to content

chore(ci): e2e tests are run on CI #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 14, 2022
Merged

chore(ci): e2e tests are run on CI #1126

merged 13 commits into from
Oct 14, 2022

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 30, 2022 •
edited
Loading

This PR does the following:

  1. Updates the build-core action so the www directory is cached (for serving index.html when running E2E tests) and so the src directory is cached (so screenshots can be collected/updated)
  2. Adds logic to a) run the playwright tests on CI and b) optionally update the snapshots
  3. Fixes a flaky test where screenshots could be taken before all the SVGs were loaded

@liamdebeasi liamdebeasi changed the title TEST DO NOT MERGE chore(ci): e2e tests are run on CI Sep 30, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review September 30, 2022 21:28
@liamdebeasi liamdebeasi merged commit 36992fc into main Oct 14, 2022
@liamdebeasi liamdebeasi deleted the p-ci branch October 14, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-perkins sean-perkins Awaiting requested review from sean-perkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamdebeasi @Ionitron