Skip to content

Conversation

@ianstormtaylor
Copy link
Contributor

to make it really easy to install for people using component

also, i'd advise tagging your releases as 1.2.0 instead of v1.2 to fit in with semver and the way most repos are tagged, since that string is used directly to grab the files

for an example of another typeface component, checkout https://github.com/typefaces/source-sans-regular

@mlynch
Copy link
Contributor

mlynch commented Oct 29, 2013

Thanks Ian! I'm going to get this in once things calm down here, had to fix a bunch of random stuff.

mlynch added a commit that referenced this pull request Oct 29, 2013
@mlynch mlynch merged commit d238838 into ionic-team:master Oct 29, 2013
@mlynch
Copy link
Contributor

mlynch commented Oct 29, 2013

Thanks again Ian, got this in there and updated the version.

@ianstormtaylor
Copy link
Contributor Author

awesome :) thanks for the quick merge, and nice job on the typeface

for semver, i'd recommend dropping the v from tags and component.json (then your component.json and bower.json will match too) since most of them don't have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants