refactor: use one same base32 package - #1192
Merged
Merged
Conversation
Two separate base32 packages were used, `whyrusleeping/base32` and `multiformats/go-base32`. This PR removes the dependency on `whyrusleeping/base32` so that boxo only depends on one base32 package.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 63.82% 63.88% +0.06%
==========================================
Files 269 269
Lines 27115 27115
==========================================
+ Hits 17306 17323 +17
+ Misses 8092 8083 -9
+ Partials 1717 1709 -8
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lidel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two separate base32 packages were used,
whyrusleeping/base32andmultiformats/go-base32. This PR removes the dependency onwhyrusleeping/base32so that boxo only depends on one base32 package.