Skip to content

refactor: use one same base32 package - #1192

Merged
lidel merged 1 commit into
mainfrom
one-base32-package
Jul 21, 2026
Merged

refactor: use one same base32 package#1192
lidel merged 1 commit into
mainfrom
one-base32-package

Conversation

@gammazero

Copy link
Copy Markdown
Contributor

Two separate base32 packages were used, whyrusleeping/base32 and multiformats/go-base32. This PR removes the dependency on whyrusleeping/base32 so that boxo only depends on one base32 package.

Two separate base32 packages were used, `whyrusleeping/base32` and `multiformats/go-base32`. This PR removes the dependency on `whyrusleeping/base32` so that boxo only depends on one base32 package.
@gammazero
gammazero requested a review from a team as a code owner July 21, 2026 21:52
@gammazero
gammazero requested a review from lidel July 21, 2026 21:53
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.88%. Comparing base (4794174) to head (2f51fc9).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
+ Coverage   63.82%   63.88%   +0.06%     
==========================================
  Files         269      269              
  Lines       27115    27115              
==========================================
+ Hits        17306    17323      +17     
+ Misses       8092     8083       -9     
+ Partials     1717     1709       -8     
Files with missing lines Coverage Δ
namesys/ipns_publisher.go 57.33% <ø> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lidel lidel changed the title refactory: use one same base32 package refactor: use one same base32 package Jul 21, 2026
@lidel
lidel merged commit dd8cfd2 into main Jul 21, 2026
28 of 29 checks passed
@lidel
lidel deleted the one-base32-package branch July 21, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants