Prep for electron-serve update - load ESM via dynamic import and disable v8-compile-cache #3048
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require(). Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Contributor
Author
|
@lidel looks like the CI could use some love :) |
This was referenced Feb 9, 2026
Member
|
Thank you @RubenKelevra! Just to set expectation, I'll likely get to reviewing these once Kubo 0.40.0-rc1 ships (i have limited availability this week) |
This was referenced Feb 10, 2026
Open
This was referenced Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @lidel, first contribution from me here in a long while :)
This PR is prep work for updating
electron-serve.Newer versions are ESM-only, so
require('electron-serve')breaks. To unblock that dependency update, this switcheselectron-serveinitialization to a dynamicimport()and awaits it during WebUI init so thewebui://-scheme is registered before any WebUI URLs are loaded. It also disables v8-compile-cache, which was causingimport()to fail in this process.Testing: I can only test on Linux. I've tested core functionality of the app under Linux with Electron
39.5.1(start/stop daemon, WebUI navigation, tray menu actions, Files tab basics).Outlook: I have more dependency updates and cleanups lined up. I'll send them as small consecutive PRs to keep each review focused and easy to approve.