Skip to content

Conversation

@RubenKelevra
Copy link
Contributor

This bumps ESLint within the current major. No behavior changes intended.

Linting is expected to fail, since #3066 introduced a new linter. :)

Testing: I can only test on Linux, and I tested the core functionality of the app with Electron 39.5.1.

Note: This commit contains the changes of PR #3048, #3049, #3050, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3061, #3062, #3063, #3064, #3065, #3066, #3067, and #3068, as soon as they are accepted, I'll remove those commits.

v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require().

Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Prep for updating i18next-icu: newer versions are ESM-only, so require() breaks.

Dynamic import works with both CommonJS and ESM.
Follow up to the ESM loader change so we can use the newer electron-serve release.
Use newer i18next-icu which requires intl-messageformat >=10.3.3.
We no longer use it (dynamic import breaks with it enabled).
Pin electron-builder to match the app-builder-lib patch and keep installs deterministic.

The patch keeps the schema tweak that allows azureSignOptions.publisherName to be a string.
Keep patching dependencies during postinstall with the current patch-package release.
Keep electron-store on a known CJS-compatible release.
Refresh common dev tools (cross-env, dotenv, got, shx, sinon, tmp, semver-regex).
Keep fs-extra current.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant