Skip to content

Check for nil in argument parsing - #1259

Closed
krl wants to merge 1 commit into
masterfrom
arg-parse-nil-check
Closed

Check for nil in argument parsing#1259
krl wants to merge 1 commit into
masterfrom
arg-parse-nil-check

Conversation

@krl

@krl krl commented May 20, 2015

Copy link
Copy Markdown
Contributor

Ipfs crashes and burns when run as a subprocess. nil-checking solves the problem, even though i don't understand exactly what is happening.

@jbenet jbenet added the status/in-progress In progress label May 20, 2015
@whyrusleeping

Copy link
Copy Markdown
Member

i'd love to understand why this fixes things before merging

@chriscool

Copy link
Copy Markdown
Contributor

@krl It looks like it should be fixed by PR #1255 (parse: fix handling of unwanted stdin).
Could you test with #1255 applied?

@ghost

ghost commented May 20, 2015

Copy link
Copy Markdown

Yeah it's a duplicate of #1255

@krl

krl commented May 20, 2015

Copy link
Copy Markdown
Contributor Author

Ok, closing this, the first crash case was solved by applying #1255
but #1260 still happens.

@krl krl closed this May 20, 2015
@jbenet jbenet removed the status/in-progress In progress label May 20, 2015
@Kubuxu
Kubuxu deleted the arg-parse-nil-check branch February 27, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants