Skip to content

object plumbing commands - #185

Merged
jbenet merged 4 commits into
ipfs:masterfrom
cryptix:cmdObjects
Oct 19, 2014
Merged

object plumbing commands#185
jbenet merged 4 commits into
ipfs:masterfrom
cryptix:cmdObjects

Conversation

@cryptix

@cryptix cryptix commented Oct 18, 2014

Copy link
Copy Markdown
Contributor

updates #138

Comment thread cmd/ipfs/objects.go

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there are any other encodings we would want to support...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on how nice we want to be. msgpack, xml, rdf, and so on do see some use.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, xml encoding might be nice to integrate with older systems

@jbenet

jbenet commented Oct 18, 2014

Copy link
Copy Markdown
Member

@cryptix awesome! thanks! a few comments up there, and one important note:

this doesn't work with a daemon, right? it's reading from os.Stdin, which is right on the client, but the code there will be executed in the daemon side, no?

Probably fine for now until we figure out what the commands library makes it look like. We'll need a way to pass io.Readers as arguments. cc @mappum

@cryptix

cryptix commented Oct 18, 2014

Copy link
Copy Markdown
Contributor Author

Jep, that's right. Same issue as with the block commands. Waiting for @mappum's cmd stuff

@cryptix

cryptix commented Oct 18, 2014

Copy link
Copy Markdown
Contributor Author

@jbenet i just noticed that I didn't yet add the commands to the daemon. So it won't work anyhow in this state.

@jbenet

jbenet commented Oct 18, 2014

Copy link
Copy Markdown
Member

@cryptix ok that's fine let's just merge it anyway and transition it to daemon later.

@jbenet

jbenet commented Oct 19, 2014

Copy link
Copy Markdown
Member

@cryptix (aside from the wording stuff, which I'll fix post merge) there's a few comments up there to address? Like:

(At least the top two, i can handle the Codec interface if not of interest)

@cryptix

cryptix commented Oct 19, 2014

Copy link
Copy Markdown
Contributor Author

Addressed the first two, not too sure where to place the codec interface and I think it's fine until we introduce more formats.

jbenet added a commit that referenced this pull request Oct 19, 2014
@jbenet
jbenet merged commit 9e3bfa2 into ipfs:master Oct 19, 2014
@cryptix
cryptix deleted the cmdObjects branch October 20, 2014 10:15
@jbenet jbenet mentioned this pull request Oct 23, 2014
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants