Skip to content

namesys: fix case where there is no cache - #3509

Merged
whyrusleeping merged 2 commits into
masterfrom
fix/namesys/dht-cache-panic
Dec 16, 2016
Merged

namesys: fix case where there is no cache#3509
whyrusleeping merged 2 commits into
masterfrom
fix/namesys/dht-cache-panic

Conversation

@Kubuxu

@Kubuxu Kubuxu commented Dec 15, 2016

Copy link
Copy Markdown
Member

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@Kubuxu Kubuxu added this to the ipfs 0.4.5 milestone Dec 15, 2016
@Kubuxu
Kubuxu requested a review from whyrusleeping December 15, 2016 01:17
@Kubuxu Kubuxu added the status/in-progress In progress label Dec 15, 2016
@Kubuxu
Kubuxu force-pushed the fix/namesys/dht-cache-panic branch from 4460882 to 08a1c37 Compare December 15, 2016 01:17
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Kubuxu force-pushed the fix/namesys/dht-cache-panic branch from 08a1c37 to 0864c8e Compare December 15, 2016 01:18
@whyrusleeping

Copy link
Copy Markdown
Member

@Kubuxu Tests? i'm not sure what scenario this actually resolves

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu

Kubuxu commented Dec 15, 2016

Copy link
Copy Markdown
Member Author

@whyrusleeping

Copy link
Copy Markdown
Member

For some weird alignment of the stars type reason all the osx tests seem to have failed... for different reasons. Rerunning them to try for better

@whyrusleeping whyrusleeping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on tests

@Kubuxu

Kubuxu commented Dec 16, 2016

Copy link
Copy Markdown
Member Author

OSX passed on Travis

@whyrusleeping
whyrusleeping merged commit f6948bb into master Dec 16, 2016
@whyrusleeping
whyrusleeping deleted the fix/namesys/dht-cache-panic branch December 16, 2016 00:41
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 16, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants