sharness: don't run go-ipfs instance with default config - #3526
Merged
Conversation
It conflicts with already running instance on the Dev's machine so running this test requires disabling the normal ipfs. The launch of ipfs here doesn't test much as we compare the config, after initing from it and we also launch from default config in many other cases (with few variables changed to not conflict with already running standalone ipfs instance). License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
whyrusleeping
approved these changes
Dec 21, 2016
whyrusleeping
left a comment
whyrusleeping
left a comment
Member
There was a problem hiding this comment.
LGTM, kinda weird to be removing tests, but youre right that this doesnt do much and is tested elsewhere.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It conflicts with already running instance on the Dev's machine so
running this test requires disabling the normal ipfs.
The launch of ipfs here doesn't test much as we compare the config,
after initing from it and we also launch from default config in many
other cases (with few variables changed to not conflict with already
running standalone ipfs instance).