AddrSplosion -- Partie Deux Avec Vengeance - #672
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
@jbenet need to hold write lock to delete these?
Member
Author
There was a problem hiding this comment.
yep, it is. defered. github's omitting it from the diff. (but would've been a great catch)
Contributor
There was a problem hiding this comment.
I meant that the lock is currently held for read access.
ab.RLock()
defer ab.RUnlock()
Contributor
There was a problem hiding this comment.
but needs to be Lock() Unlock() since there exist map deletions.
Member
Author
There was a problem hiding this comment.
Ahhhh great catch. right you are. thanks
jbenet
added a commit
that referenced
this pull request
Jan 27, 2015
AddrSplosion -- Partie Deux Avec Vengeance
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the effects of addr-splosion.
receive ground truth from the peer itself.
TTL (for now set to 1hr). After which nodes
must resolve addrs again. (this may be too
aggressive and can be revisited once we bring
in proper addr management)
Related to: #573, #603