return connected peers as providers - #686
Merged
Merged
Conversation
jbenet
force-pushed
the
exchange-with-connected
branch
from
January 29, 2015 09:10
1456ec1 to
64191c1
Compare
Member
Author
|
@briantigerchow I made the required change to make Bootstrap sync. |
Member
There was a problem hiding this comment.
why not range over connectedPeers what if its value changes during the time between calls? Could hang if a peer is added in the meantime
dialing 4000 connections somehow keeps choking both travis and jenkins. dialing this down to 500
Contributor
|
LGTM |
jbenet
added a commit
that referenced
this pull request
Jan 29, 2015
return connected peers as providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: