Skip to content

fix: add backing buffer type to Uint8Array fields #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achingbrain merged 1 commit into from
Jul 1, 2026
Merged

fix: add backing buffer type to Uint8Array fields #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/protons/src/types/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type { Type } from './index.ts'

const types: Record<string, string> = {
bool: 'boolean',
bytes: 'Uint8Array',
bytes: 'Uint8Array<ArrayBuffer>',
double: 'number',
fixed32: 'number',
fixed64: 'bigint',
Expand Down
30 changes: 15 additions & 15 deletions packages/protons/test/fixtures/bitswap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { Uint8ArrayList } from 'uint8arraylist'

export interface Message {
wantlist?: Message.Wantlist
blocks: Uint8Array[]
blocks: Uint8Array<ArrayBuffer>[]
payload: Message.Block[]
blockPresences: Message.BlockPresence[]
pendingBytes: number
Expand Down Expand Up @@ -35,7 +35,7 @@ export namespace Message {
}

export interface Entry {
block: Uint8Array
block: Uint8Array<ArrayBuffer>
priority: number
cancel?: boolean
wantType: Message.Wantlist.WantType
Expand Down Expand Up @@ -178,7 +178,7 @@ export namespace Message {

export interface EntryBlockFieldEvent {
field: '$.block'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface EntryPriorityFieldEvent {
Expand Down Expand Up @@ -322,7 +322,7 @@ export namespace Message {

export interface WantlistEntriesBlockFieldEvent {
field: '$.entries[].block'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
index: number
}

Expand Down Expand Up @@ -369,8 +369,8 @@ export namespace Message {
}

export interface Block {
prefix: Uint8Array
data: Uint8Array
prefix: Uint8Array<ArrayBuffer>
data: Uint8Array<ArrayBuffer>
}

export namespace Block {
Expand Down Expand Up @@ -459,12 +459,12 @@ export namespace Message {

export interface BlockPrefixFieldEvent {
field: '$.prefix'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface BlockDataFieldEvent {
field: '$.data'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export function encode (obj: Partial<Block>): Uint8Array<ArrayBuffer> {
Expand Down Expand Up @@ -497,7 +497,7 @@ export namespace Message {
}

export interface BlockPresence {
cid: Uint8Array
cid: Uint8Array<ArrayBuffer>
type: Message.BlockPresenceType
}

Expand Down Expand Up @@ -587,7 +587,7 @@ export namespace Message {

export interface BlockPresenceCidFieldEvent {
field: '$.cid'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface BlockPresenceTypeFieldEvent {
Expand Down Expand Up @@ -803,7 +803,7 @@ export namespace Message {

export interface MessageWantlistEntriesBlockFieldEvent {
field: '$.wantlist.entries[].block'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
index: number
}

Expand Down Expand Up @@ -839,24 +839,24 @@ export namespace Message {
export interface MessageBlocksFieldEvent {
field: '$.blocks[]'
index: number
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface MessagePayloadPrefixFieldEvent {
field: '$.payload[].prefix'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
index: number
}

export interface MessagePayloadDataFieldEvent {
field: '$.payload[].data'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
index: number
}

export interface MessageBlockPresencesCidFieldEvent {
field: '$.blockPresences[].cid'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
index: number
}

Expand Down
16 changes: 8 additions & 8 deletions packages/protons/test/fixtures/circuit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ export namespace CircuitRelay {
}

export interface Peer {
id: Uint8Array
addrs: Uint8Array[]
id: Uint8Array<ArrayBuffer>
addrs: Uint8Array<ArrayBuffer>[]
}

export namespace Peer {
Expand Down Expand Up @@ -184,13 +184,13 @@ export namespace CircuitRelay {

export interface PeerIdFieldEvent {
field: '$.id'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface PeerAddrsFieldEvent {
field: '$.addrs[]'
index: number
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export function encode (obj: Partial<Peer>): Uint8Array<ArrayBuffer> {
Expand Down Expand Up @@ -329,24 +329,24 @@ export namespace CircuitRelay {

export interface CircuitRelaySrcPeerIdFieldEvent {
field: '$.srcPeer.id'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface CircuitRelaySrcPeerAddrsFieldEvent {
field: '$.srcPeer.addrs[]'
index: number
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface CircuitRelayDstPeerIdFieldEvent {
field: '$.dstPeer.id'
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface CircuitRelayDstPeerAddrsFieldEvent {
field: '$.dstPeer.addrs[]'
index: number
value: Uint8Array
value: Uint8Array<ArrayBuffer>
}

export interface CircuitRelayCodeFieldEvent {
Expand Down
Loading
Loading