refactor: split reframe specs#292
Merged
aschmahmann merged 1 commit intoreframe-cachingfrom Jun 24, 2022
Merged
Conversation
Implements split proposed in #287 (review) This decouples Transports and Known Methods from the generic RPC protocol, and allows us to add more methods and transports without touching the protocol itself.
3 tasks
willscott
approved these changes
Jun 22, 2022
Contributor
willscott
left a comment
willscott
left a comment
There was a problem hiding this comment.
I'm happy to see this refactored into a directory.
for extensibility, might consider splitting further into 'methods' (containing identify), 'methods_ipns', and 'methods_findproviders'
petar
approved these changes
Jun 22, 2022
Member
Author
|
@aschmahmann ok to this into #287, and merge that one as well? |
aschmahmann
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR decouples Transports and Known Methods from the generic RPC protocol and moves everything under
./reframedirectory, as proposed in #287 (review)Filled as PR against that PR for easier review (same content, different presentation).
(cc @aschmahmann @petar @willscott)
Why should we do this split?
We don't have to, but it will make things easier to navigate going forward:
It allows us to add/modify methods and transports without touching the protocol itself.
PREVIEW
Rendered Markdown: https://github.com/ipfs/specs/tree/refactor/split-reframe-specs/reframe