Reframe: specify HTTP response status codes#311
Merged
Conversation
willscott
approved these changes
Aug 23, 2022
Contributor
willscott
left a comment
willscott
left a comment
There was a problem hiding this comment.
should we specify semantics of 4xx vs 5xx responses?
e.g. 4xx on client errors (malformed request / etc) and 5xx on server errors
Contributor
Author
|
How about I say something like "Non-200 status codes SHOULD follow best practices, e.g. 4xx on client errors, 5xx on server errors, etc.". |
Contributor
|
yeah, or it's fine as is. i think the implicit conventions of HTTP basically work for us here. |
Contributor
Author
|
(Side note: @lidel is out this week so I am merging this without approval from him, despite his being a code owner.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.