perf(tests): trim playwright select2 delays + remove dead pbn_integrator stub#236
Merged
Conversation
- Remove delay=50 from press_sequentially() - no longer needed - Change wait_for_timeout(50) to wait_for_timeout(0) - wait for next event loop tick instead - Change wait_for_timeout(100) to wait_for_timeout(0) - wait for next event loop tick instead These delays were historical band-aids that accumulated across multiple Select2 interactions in Playwright tests. Modern event-driven waiting strategies make them unnecessary. Zero-timer waits still allow the JavaScript event loop to process pending microtasks, which is what the original waits were trying to accomplish. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove 149 lines of stub functions with time.sleep() calls that are shadowing working implementations in: - pbn_integrator/importer/ (importuj_zrodla, importuj_publikacje_*) - import_common/core/uczelnia.py (matchuj_uczelnie) Nothing imports from this module - it's leftover placeholder code from the initial pbn_integrator implementation that was never cleaned up. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright_util.py: usuwadelay=50zpress_sequentially, zmniejsza dwawait_for_timeout(50/100)do0(yield event loop tick zamiast realnego sleepa).src/pbn_integrator/core/__init__.py— sametime.sleep+ fikcyjne returny, nic z tego nie było używane.Test plan
make tests-without-playwrightselect_select2_autocomplete(smoke zsrc/integration_tests/)ruff check . && ruff format --check .🤖 Generated with Claude Code