Skip to content

perf(tests): trim playwright select2 delays + remove dead pbn_integrator stub #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpasternak merged 2 commits into from
May 21, 2026
Merged

perf(tests): trim playwright select2 delays + remove dead pbn_integrator stub #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3596bc4
perf(tests): remove unnecessary fixed delays in playwright_util.py
mpasternak May 4, 2026
e8359a5
refactor: remove dead code pbn_integrator/core/__init__.py
mpasternak May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/django_bpp/playwright_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def select_select2_autocomplete(

# Type the search term using pressSequentially to trigger AJAX search
search_input = page.locator(".select2-search__field")
search_input.press_sequentially(value, delay=50)
search_input.press_sequentially(value)

# Wait for AJAX search to complete by checking for loading indicators to disappear
# Polish text "Trwa wyszukiwanie…" or "Trwa ładowanie…" indicates loading
Expand Down Expand Up @@ -130,11 +130,11 @@ def select_select2_autocomplete(
timeout=timeout,
)
else:
# No event-driven signal available — small polishing wait so the
# next interaction starts after Select2's internal change handlers
# finish (jQuery 'change' listeners run synchronously, but custom
# widgets may queue setTimeout(0) callbacks).
page.wait_for_timeout(50)
# No event-driven signal available — wait for next event loop tick
# so Select2's internal change handlers finish (jQuery 'change'
# listeners run synchronously, but custom widgets may queue
# setTimeout(0) callbacks).
page.wait_for_timeout(0)


def close_all_select2_dropdowns(page: Page):
Expand All @@ -150,7 +150,7 @@ def close_all_select2_dropdowns(page: Page):
}
}"""
)
page.wait_for_timeout(100)
page.wait_for_timeout(0)


def proper_click_element(page: Page, selector: str):
Expand Down
148 changes: 0 additions & 148 deletions src/pbn_integrator/core/__init__.py
View file
Open in desktop

This file was deleted.

Loading