Skip to content

Fix/windows ci tests#4018

Draft
nv-apoddubny wants to merge 27 commits into
isaac-sim:mainfrom
nv-apoddubny:fix/windows-ci-tests
Draft

Fix/windows ci tests#4018
nv-apoddubny wants to merge 27 commits into
isaac-sim:mainfrom
nv-apoddubny:fix/windows-ci-tests

Conversation

@nv-apoddubny
Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added bug Something isn't working isaac-mimic Related to Isaac Mimic team infrastructure labels Nov 14, 2025
@nv-apoddubny nv-apoddubny force-pushed the fix/windows-ci-tests branch 6 times, most recently from 2bf6daa to a5a3ae7 Compare November 25, 2025 20:13
@Mayankm96 Mayankm96 force-pushed the main branch 2 times, most recently from 2ef7fc8 to f3061a4 Compare January 28, 2026 16:16
@myurasov-nv myurasov-nv added the windows Windows-specific issue label Feb 9, 2026
hujc7 added a commit to hujc7/IsaacLab that referenced this pull request May 22, 2026
Extend the workflow-level env block with the headless/no-window/EULA
flags that PR isaac-sim#4018's known-working build.yml proved out:
  ISAACSIM_ACCEPT_EULA=YES        # different layer from ACCEPT_EULA
  HEADLESS=1, ISAAC_SIM_HEADLESS=1, ISAAC_SIM_LOW_MEMORY=1
  WINDOWS_PLATFORM=true
  OMNI_KIT_NO_WINDOW=1            # critical: blocks Kit from trying to
                                  # open a display when no desktop session
  OMNI_KIT_DISABLE_WATCHDOG=1, OMNI_KIT_TELEMETRY=0
  CARB_LOGGING_SEVERITY=error
  PYTHONUNBUFFERED=1, PYTHONIOENCODING=utf-8

Add .github/actions/windows-sim-paths/ composite action that re-activates
the caller's venv, resolves the Isaac Sim install root via
pip show isaacsim-kernel, and exports:
  ISAAC_PATH, CARB_APP_PATH (sim/kit), EXP_PATH (workspace/apps), RESOURCE_NAME

It also prepends <sim>/kit/plugins and <sim>/bin to PATH so the Vulkan
loader can find NVIDIA's ICD DLLs (likely root cause of
'vkEnumeratePhysicalDevices failed. No physical device is found.' on
this runner — DLL search defaults do not include the Sim install).

Wire into kit-launch-windows and perception-windows by splitting their
'install + launch' steps into three: install isaacsim, resolve Sim
paths (this action), boot Kit. Install-windows and path-io-windows
don't boot Kit so don't need this.

Extend the windows-instance-state action's report with nvidia-smi
output so 'no GPU' vs 'GPU present, Vulkan can't load' is visible
in every job's pre-state dump. Also harden the size measurement
against junctions/reparse points that have no Length property
(suppresses the GenericMeasurePropertyNotFound noise observed
in the previous run).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure isaac-mimic Related to Isaac Mimic team windows Windows-specific issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants