-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fixes returned tensor for normals in TiledCamera #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi reviewers! I wonder if I need to (and how to) create tests and/or update the changelog for this bug fix. |
Mayankm96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! Could we also modify the unit tests to capture this case?
|
Hi @Mayankm96 , thank you for your reply! I am happy to update the unit tests, but unfortunately I have run into issues running the unit tests for TiledCamera (#4255). |
|
Hi @Mayankm96 ! I have updated the unit test to capture the previous bug. I added an assertion to verify that the norms of the normals should be approximately 1. The previous (buggy) version would fail here because of the shift.
I also updated several existing assertions for the camera data keys in other test cases for I have verified that the fixed code can pass all test cases in the updated unit tests in |
|
If I understand the issue correctly, the fix is discarding the fourth channel before reshaping. But I see implementation added a new output_type called normal_padded, is that needed? |
…al_padded in earlier commits)
|
Hi @ooctipus , thank you. I just realized that adding a new output key was indeed unnecessary. I changed it to a simpler fix. The unit test has been updated accordingly, capturing the previous bug without making unnecessary changes. |

Description
Fix a bug with
TiledCamera. The 4-th channel in the "normals" annotator output should be discarded before reshaping into [B, H, W, 3]. Please find more details in the issue below:Fixes #4239
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there