Skips failing tests for UR10e robot with Robotiq gripper#4316
Skips failing tests for UR10e robot with Robotiq gripper#4316Mayankm96 merged 6 commits intoisaac-sim:mainfrom
Conversation
Greptile SummaryThis PR temporarily disables failing tests to unblock CI pipeline. Two changes were made:
The author acknowledges this is a temporary workaround and notes that the UR10e Robotiq issue "needs proper debugging." The FIXME comment indicates this skip should be revisited once the root cause is identified and resolved. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant TestRunner as Test Runner
participant TestConfig as test_valid_configs.py
participant Assets as isaaclab_assets
participant Config as UR10e_ROBOTIQ_GRIPPER_CFG
participant Nucleus as Nucleus Server
participant SkrlTest as test_skrl_wrapper.py
participant TestSettings as test_settings.py
TestRunner->>TestConfig: Run test_asset_configs()
TestConfig->>Assets: Iterate through all configs in dir(lab_assets)
Assets->>TestConfig: Return config objects
alt UR10e_ROBOTIQ_GRIPPER_CFG encountered
TestConfig->>TestConfig: Check if obj_name == "UR10e_ROBOTIQ_GRIPPER_CFG"
TestConfig->>TestConfig: Skip with continue (FIXME)
Note over TestConfig: Skipped due to Nucleus issue
else Other configs
TestConfig->>Config: Create asset instance
Config->>Nucleus: Load USD with variant {"Gripper": "Robotiq_2f_140"}
Nucleus-->>Config: Return asset (may fail for UR10e)
Config->>TestConfig: Asset initialized
TestConfig->>TestConfig: Assert is_initialized
end
TestRunner->>SkrlTest: Run test_skrl_wrapper()
SkrlTest->>TestSettings: Check timeout for test
TestSettings-->>SkrlTest: Return 500 seconds (increased from default)
SkrlTest->>SkrlTest: Execute test with extended timeout
SkrlTest-->>TestRunner: Complete within timeout
|
There was a problem hiding this comment.
Additional Comments (1)
-
source/isaaclab_assets/test/test_valid_configs.py, line 36-39 (link)style: The comment mentions "recent Nucleus update" without specifics. Consider adding a link to an issue tracking the root cause and what specifically fails (variant not found, USD loading error, etc.) to prevent this skip from becoming permanent.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
2 files reviewed, 1 comment
|
I'm facing the same issue in this PR: #4044 Is this because the UR10e_ROBOTIQ_2F_85_CFG.spawn.variants is not taking effect for some reason? These tests seem to pass locally for me. And the variant seem to load fine for me locally. |
|
After discussion with @stevfeng -- We have identified the issue. It is because the assets internally refer to the "dev" nucleus server. Hence, the variant selection was hanging. |
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
) # Description This MR skips tests that are failing. Even after debugging, I couldn't really arrive at a solution. It needs proper debugging but don't want to block incoming MRs. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
|
@Mayankm96 The tests seems to be passing now. Shouldn't we revert this PR? |
…)" This reverts commit 0aa7837.
# Description Reverting to runs skipped tests which should pass with the updates UR10e USD that does not have references to internal nucleus assets. Reverts this PR partly #4316.
) # Description This MR skips tests that are failing. Even after debugging, I couldn't really arrive at a solution. It needs proper debugging but don't want to block incoming MRs. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
# Description Reverting to runs skipped tests which should pass with the updates UR10e USD that does not have references to internal nucleus assets. Reverts this PR partly isaac-sim#4316.
# Description Reverting to runs skipped tests which should pass with the updates UR10e USD that does not have references to internal nucleus assets. Reverts this PR partly isaac-sim/IsaacLab#4316.
) # Description This MR skips tests that are failing. Even after debugging, I couldn't really arrive at a solution. It needs proper debugging but don't want to block incoming MRs. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
# Description Reverting to runs skipped tests which should pass with the updates UR10e USD that does not have references to internal nucleus assets. Reverts this PR partly isaac-sim#4316.
Description
This MR skips tests that are failing. Even after debugging, I couldn't really arrive at a solution. It needs proper debugging but don't want to block incoming MRs.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there