Migrating assets from torch to warp#4551
Merged
kellyguo11 merged 51 commits intoisaac-sim:developfrom Feb 13, 2026
Merged
Conversation
AntoineRichard
force-pushed
the
antoiner/warp
branch
from
137bd2d to
c9ef755
Compare
ooctipus
reviewed
Feb 11, 2026
| def write_nodal_pos_to_sim_index( | ||
| self, | ||
| nodal_pos: torch.Tensor | wp.array, | ||
| env_ids: Sequence[int] | torch.Tensor | wp.array | None = None, |
Collaborator
There was a problem hiding this comment.
do we still want to support Sequence[int]?
ooctipus
reviewed
Feb 11, 2026
| @@ -190,14 +193,19 @@ def permanent_wrench_composer(self) -> WrenchComposer: | |||
| Operations. | |||
| """ | |||
|
|
|||
| def reset(self, env_ids: Sequence[int] | None = None): | |||
| # FIXME: Support env_mask. | |||
Collaborator
There was a problem hiding this comment.
we can remove this comment
ooctipus
reviewed
Feb 11, 2026
| def write_root_state_to_sim(self, root_state: torch.Tensor, env_ids: Sequence[int] | None = None): | ||
| def write_root_state_to_sim_index( | ||
| self, root_state: torch.Tensor | wp.array, | ||
| env_ids: Sequence[int] | torch.Tensor | wp.array | None = None, |
Collaborator
There was a problem hiding this comment.
the implementation looks like Sequence[int] won't work but argument type hint still marks Sequence[int]
Collaborator
|
Thanks Antoine I think with this PR, our code will become a lot more standardized and efficient. Im happy to merge once test cases are showing similar passing result. |
AntoineRichard
force-pushed
the
antoiner/warp
branch
from
5c5efe0 to
ee10e4b
Compare
…_data.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Antoine RICHARD <antoiner@nvidia.com>
…_data.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Antoine RICHARD <antoiner@nvidia.com>
…rectly set by IsaacSim on the warp backend.
AntoineRichard
force-pushed
the
antoiner/warp
branch
from
d3211ac to
08bd747
Compare
AntoineRichard
requested review from
Mayankm96,
Toni-SM,
jtigue-bdai,
kellyguo11,
pascal-roth and
xyao-nv
as code owners
Contributor
|
Too many files changed for review. ( |
github-actions
bot
added
the
documentation
kellyguo11
reviewed
Feb 13, 2026
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
kellyguo11
approved these changes
Feb 13, 2026
7 tasks
kellyguo11
added a commit
that referenced
this pull request
Feb 14, 2026
# Description Fixes some more failing tests that were introduced in #4551 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Antoine RICHARD <antoiner@nvidia.com> Co-authored-by: Antoine Richard <antoiner@nvidia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there