Skip to content

Fixes various installation bugs#5530

Merged
kellyguo11 merged 6 commits intoisaac-sim:developfrom
myurasov-nv:my-nvbugs-2
May 8, 2026
Merged

Fixes various installation bugs#5530
kellyguo11 merged 6 commits intoisaac-sim:developfrom
myurasov-nv:my-nvbugs-2

Conversation

@myurasov-nv
Copy link
Copy Markdown
Member

@myurasov-nv myurasov-nv commented May 7, 2026

Description

Fixed bugs:

  • [NVBug 6122918] - Grammar in installation docs (these dependency -> these dependencies; drop redundant guides after ``:ref:`how-to```).
  • [NVBug 6125106] - Add an Environment setup section to the kit-less install page so it does not jump from git clone straight to ./isaaclab.sh --install.
  • [NVBug 6125054] - Relax starlette==0.49.1 -> >=0.46.0,<0.50 so isaaclab[isaacsim,all]==3.0.0 resolves alongside isaacsim==6.0.0.0 (transitively requires starlette<0.49.0).
  • [NVBug 6122885] - Bump recommended driver versions on the installation index to the Beta2 POR (Linux 580.95.05, Spark 580.142, Windows 581.42.00).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml -- CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added bug Something isn't working documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team infrastructure labels May 7, 2026
@myurasov-nv myurasov-nv changed the title Fix Beta2 install, docs, and preset issues (5 NVBugs) Fixes some NVBugs May 7, 2026
@myurasov-nv myurasov-nv marked this pull request as ready for review May 7, 2026 07:05
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Greptile Summary

This PR bundles four small Beta2 acceptance-gating fixes: a grammar correction in build docs, a cross-reference cleanup in verification docs, driver version bumps to Beta2 POR, an environment-setup section added to the kit-less install page, and a relaxation of the starlette pin from ==0.49.1 to >=0.46.0,<0.50 so isaaclab[isaacsim,all]==3.0.0 can resolve alongside isaacsim==6.0.0.0.

  • Driver versions in index.rst updated to Linux 580.95.05, Spark 580.142, Windows 581.42.00.
  • starlette dependency relaxed in both setup.py and python_packages.toml; changelog fragment and comments are consistent.
  • Kit-less install page gains a "Preparing a Python Environment" section via the shared pip_python_virtual_env.rst include, closing the gap between git clone and ./isaaclab.sh --install.

Confidence Score: 5/5

All changes are documentation updates or a narrow dependency range relaxation with a well-documented rationale; nothing touches runtime logic.

The starlette range change is clearly motivated, constrained, and kept in sync across both setup.py and python_packages.toml. Documentation changes are additive and correct. No runtime code is modified.

No files require special attention; the only minor note is that the shared pip_python_virtual_env.rst include on the kit-less page contains Isaac Sim-specific language that may briefly confuse kit-less users.

Important Files Changed

Filename Overview
docs/source/setup/installation/kitless_installation.rst Adds an "Environment setup" section by including pip_python_virtual_env.rst; the included file references Isaac Sim requirements which may be confusing in a kit-less context.
source/isaaclab/setup.py Relaxes starlette pin from ==0.49.1 to >=0.46.0,<0.50 to resolve alongside isaacsim 6.0.0.0; range and comment are correct and in sync with python_packages.toml.
tools/wheel_builder/res/python_packages.toml Starlette constraint kept in sync with setup.py; old TODO comment removed.
docs/source/setup/installation/index.rst Driver version table updated to Beta2 POR: Linux 580.95.05, Spark 580.142, Windows 581.42.00.
source/isaaclab/changelog.d/my-nvbugs-2.rst New changelog fragment documenting the starlette relaxation; version range matches setup.py and python_packages.toml.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Kit-less Install Page] --> B[pip_python_virtual_env.rst\nEnvironment Setup - NEW]
    B --> C[Create Python 3.12 venv\nuv / conda]
    C --> D[Clone Isaac Lab\ngit clone]
    D --> E[./isaaclab.sh --install]

    subgraph dep[Dependency Resolution]
        F[isaaclab setup.py\nstarlette >=0.46.0,<0.50]
        G[python_packages.toml\nstarlette >=0.46.0,<0.50]
        H[isaacsim-kernel\nfastapi==0.117.1 → starlette<0.49.0]
        F -- resolves with --> H
        G -- in sync with --> F
    end
Loading

Reviews (3): Last reviewed commit: "Tighten starlette lower bound from 0.40 ..." | Re-trigger Greptile

Comment thread source/isaaclab/setup.py Outdated
Comment thread source/isaaclab/isaaclab/sensors/camera/camera_cfg.py Outdated
Comment thread tools/wheel_builder/res/python_packages.toml Outdated
@myurasov-nv
Copy link
Copy Markdown
Member Author

@greptile-apps

Comment thread source/isaaclab/changelog.d/my-nvbugs-2.rst Outdated
@kellyguo11 kellyguo11 changed the title Fixes some NVBugs Fixes various installation bugs May 8, 2026
Comment thread source/isaaclab/isaaclab/sensors/camera/camera_cfg.py Outdated
@myurasov-nv
Copy link
Copy Markdown
Member Author

@greptile-apps

@kellyguo11 kellyguo11 merged commit 8d9af88 into isaac-sim:develop May 8, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants