Adds isaaclab_teleop as dependency of isaaclab_mimic during mimic only install#5820
Conversation
Greptile SummaryThis PR fixes a missing-import error when running mimic data generation after a
Confidence Score: 4/5The install fix is minimal and correct; the only issue is a misleading sentence in one changelog file. The core change in install.py is a one-line tuple expansion that correctly places isaaclab_teleop before isaaclab_mimic, and the deduplication guard in append_submodules_once ensures no double-install occurs when both mimic and teleop are requested. The test is updated to match. The only imperfection is the isaaclab_mimic changelog entry, which claims a config/extension.toml modification that was never made. source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst — the first sentence references an extension.toml change that does not exist in this PR. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["./isaaclab.sh -i mimic"] --> B["split_install_items('mimic')"]
B --> C{"name in OPTIONAL_ISAACLAB_SUBMODULES?"}
C -- yes --> D["append_submodules_once(('isaaclab_teleop', 'isaaclab_mimic'))"]
D --> E{"pkg_dir already in list?"}
E -- no --> F["Append to submodules_to_install"]
E -- yes --> G["Skip (deduplicated)"]
F --> H["pip install -e source/isaaclab_teleop"]
F --> I["pip install -e source/isaaclab_mimic"]
H --> I
Reviews (1): Last reviewed commit: "make isaaclab_teleop a dep of isaaclab_m..." | Re-trigger Greptile |
Signed-off-by: peterd-NV <peterd@nvidia.com>
… teleop/mimic dependency (#5829) # Description Cherry pick bug fix PRs from develop: - #5821 - #5820 - #5733 - #5824 --------- Signed-off-by: peterd-NV <peterd@nvidia.com> Co-authored-by: peterd-NV <peterd@nvidia.com> Co-authored-by: ooctipus <zhengyuz@nvidia.com> Co-authored-by: matthewtrepte <mtrepte@nvidia.com>
Description
Adds isaaclab_teleop as a dep to isaaclab_mimic when using
./isaaclab.sh -i mimicFixes # (issue)
Previously when a user installs just mimic and tried to run data generation, an error would occur as isaaclab teleop was not installed. This change fixes the import error.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there