Document Digit closed-loop articulation limitation on Newton#5821
Conversation
The Newton ArticulationView walks model.joint_child without deduplicating, so closed-loop articulations like Agility Digit end up with link_count larger than the number of unique physical bodies (49 vs 43 on Digit). Downstream this breaks any code path that assumes one entry per logical body. Drop newton_mjwarp from the three Digit env rows in the supported environments tables and add a "Closed-loop articulations on Newton" entry under Known Issues describing the root cause and pointing users to the physx preset until the upstream fix lands.
Greptile SummaryThis is a documentation-only PR that corrects the supported-physics-preset claims for the three Agility Digit locomotion environments and adds a Known Issues entry explaining the underlying Newton
Confidence Score: 5/5Documentation-only change that removes misleading preset claims and adds a workaround guide; no runtime code is modified. All three Digit environment entries are consistently updated in both the grid table and the list-tables in environments.rst, the new Known Issues section in issues.rst is accurate and well-structured, and the .skip sentinel file correctly indicates no changelog entry is needed. Nothing executable changes. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Select Isaac Lab Environment] --> B{Robot has closed-loop\nkinematic chain?}
B -- Yes\ne.g. Agility Digit --> C[Use physx preset]
B -- No\ne.g. Anymal, G1, H1... --> D{Preferred preset?}
D --> E[physx]
D --> F[newton_mjwarp]
C --> G[Environment runs correctly]
E --> G
F --> G
subgraph Known Issue
H[Newton ArticulationView\nwalk joint_child without dedup\nlink_count > unique bodies\ne.g. Digit: 49 slots vs 43 bodies]
end
B -- Yes --> H
H --> C
Reviews (1): Last reviewed commit: "Document Digit closed-loop articulation ..." | Re-trigger Greptile |
… teleop/mimic dependency (#5829) # Description Cherry pick bug fix PRs from develop: - #5821 - #5820 - #5733 - #5824 --------- Signed-off-by: peterd-NV <peterd@nvidia.com> Co-authored-by: peterd-NV <peterd@nvidia.com> Co-authored-by: ooctipus <zhengyuz@nvidia.com> Co-authored-by: matthewtrepte <mtrepte@nvidia.com>
Summary
newton_mjwarpfrom the three Digit env rows indocs/source/overview/environments.rst(Isaac-Velocity-Flat-Digit-v0,Isaac-Velocity-Rough-Digit-v0,Isaac-Tracking-LocoManip-Digit-v0).docs/source/refs/issues.rstdescribing the root cause and recommending thephysxpreset until the upstream fix lands.Why
Robots with closed kinematic loops (Digit's achilles rod and toe push-rods) do not run correctly under the
newton_mjwarpphysics preset today. Newton'sArticulationViewbuilds its per-link axis by walkingmodel.joint_childover the articulation's joint range andsorted()-ing without deduplication, so a body that is the child of N joints occupies N slots on that axis. On Digit this givesview.link_count = 49against 43 unique physical bodies; the four loop-closed bodies (left/righttarsus, left/righttoe_roll) account for the six extra slots. Any code path that assumes one entry per logical body breaks (e.g. tensor-shape mismatches infeet_slide-style rewards).The supported-environments tables previously listed
newton_mjwarpfor Digit, which is misleading. This PR removes that claim and documents the limitation under Known Issues.Test plan
./isaaclab.sh -f(pre-commit) passes locally.physx.