Skip to content

Bump newton version pin to 79e95bf5571d70a0a46c8eaedc80644531d27368 - #6242

Merged
huidongc merged 1 commit into
isaac-sim:developfrom
huidongc:bump-newton-version
Jun 24, 2026
Merged

Bump newton version pin to 79e95bf5571d70a0a46c8eaedc80644531d27368#6242
huidongc merged 1 commit into
isaac-sim:developfrom
huidongc:bump-newton-version

Conversation

@huidongc

@huidongc huidongc commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixed the newton[sim] dependency pin to use Newton commit 79e95bf5571d70a0a46c8eaedc80644531d27368, including the RenderContext triangle-mesh construction fix from newton-physics/newton#3199.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added isaac-lab Related to Isaac Lab team infrastructure labels Jun 23, 2026
@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the newton[sim] dependency pin from commit 811968b to 79e95bf across all sub-packages and the wheel builder, pulling in the RenderContext triangle-mesh construction fix from newton-physics/newton#3199.

  • Updated the git-pinned commit hash in source/isaaclab_newton/pyproject.toml, source/isaaclab_physx/pyproject.toml, source/isaaclab_visualizers/pyproject.toml (all four extras groups), and tools/wheel_builder/res/python_packages.toml — all hashes are consistent.
  • Added matching bump-newton-pin.rst changelog fragments for each affected package (isaaclab, isaaclab_newton, isaaclab_physx, isaaclab_visualizers).

Confidence Score: 5/5

Straightforward dependency pin bump with no logic changes; all four pin sites are updated to the same commit hash and each has a matching changelog entry.

Every occurrence of the old commit hash has been replaced with the new one, and changelog fragments are present for all affected packages. The change is purely a version pin update with no code modifications.

No files require special attention.

Important Files Changed

Filename Overview
source/isaaclab_newton/pyproject.toml Bumps newton[sim] commit pin from 811968b to 79e95bf in the all optional-dependency group.
source/isaaclab_physx/pyproject.toml Bumps newton[sim] commit pin from 811968b to 79e95bf in the newton optional-dependency group.
source/isaaclab_visualizers/pyproject.toml Bumps newton[sim] commit pin from 811968b to 79e95bf across all four optional-dependency groups (newton, rerun, viser, all).
tools/wheel_builder/res/python_packages.toml Bumps newton[sim] commit pin from 811968b to 79e95bf in the wheel-builder newton extras definition.
source/isaaclab/changelog.d/bump-newton-pin.rst New changelog fragment for the main isaaclab package documenting the wheel-builder newton pin update.
source/isaaclab_newton/changelog.d/bump-newton-pin.rst New changelog fragment for isaaclab_newton documenting the newton pin update.
source/isaaclab_physx/changelog.d/bump-newton-pin.rst New changelog fragment for isaaclab_physx documenting the newton pin update.
source/isaaclab_visualizers/changelog.d/bump-newton-pin.rst New changelog fragment for isaaclab_visualizers documenting the newton pin update.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["newton-physics/newton@79e95bf\n(RenderContext triangle-mesh fix)"] --> B["isaaclab_newton\npyproject.toml – all extras"]
    A --> C["isaaclab_physx\npyproject.toml – newton extras"]
    A --> D["isaaclab_visualizers\npyproject.toml – newton / rerun / viser / all extras"]
    A --> E["tools/wheel_builder\nres/python_packages.toml – newton extras"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["newton-physics/newton@79e95bf\n(RenderContext triangle-mesh fix)"] --> B["isaaclab_newton\npyproject.toml – all extras"]
    A --> C["isaaclab_physx\npyproject.toml – newton extras"]
    A --> D["isaaclab_visualizers\npyproject.toml – newton / rerun / viser / all extras"]
    A --> E["tools/wheel_builder\nres/python_packages.toml – newton extras"]
Loading

Reviews (1): Last reviewed commit: "bump newton version" | Re-trigger Greptile

@huidongc
huidongc merged commit 4095417 into isaac-sim:develop Jun 24, 2026
38 checks passed
@huidongc
huidongc deleted the bump-newton-version branch June 24, 2026 01:18
huidongc added a commit to huidongc/IsaacLab that referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants