Remove obsolete de-instancing workaround in test and fix rendering test failures due to reuse of SimpleShadingSD

[huidongc]

Description

• Fixed :class:~isaaclab_physx.renderers.IsaacRtxRenderer failing with Annotator SimpleShadingSD is not attached to any render products when multiple environments sequentially request simple_shading_* camera outputs in the same Kit process. Each tiled render product is named from the requested data types, and the owned HydraTexture is destroyed on cleanup to avoid leaking render products across env create/destroy cycles.

• Remove the NVBUG#6418121 workaround from Franka cloth and soft-body rendering tests now that the issue has been fixed by upstream Kit components.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Test change

Checklist

• I have read and understood the contribution guidelines
• I have run the pre-commit checks with ./isaaclab.sh --format
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
• I have added my name to the CONTRIBUTORS.md or my name already exists there

[greptile-apps]

Greptile Summary

This PR updates RTX render-product ownership and rendering-test expectations.

• Names tiled render products from requested camera output types.
• Retains and explicitly destroys each renderer-owned tiled render product during cleanup.
• Clears renderer-owned annotator, output, ISP, and scratch-buffer references during cleanup.
• Removes the obsolete rendering-instancing workaround and updates affected Franka cloth golden images.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
source/isaaclab_physx/isaaclab_physx/renderers/isaac_rtx_renderer.py	Changes render-product data ownership, assigns output-derived names, and explicitly releases renderer resources during camera cleanup.
source/isaaclab_tasks/test/rendering_test_utils.py	Removes the obsolete USD-instancing workaround and re-enables the associated rendering-test paths.
source/isaaclab_tasks/test/golden_images/franka_cloth/newton-isaacsim_rtx_renderer-rgb.png	Updates the expected Franka cloth RGB rendering output after removing the workaround.
source/isaaclab_tasks/test/golden_images/franka_cloth/newton-isaacsim_rtx_renderer-rgba.png	Updates the expected Franka cloth RGBA rendering output after removing the workaround.

Sequence Diagram

sequenceDiagram
    participant Camera
    participant Renderer as IsaacRtxRenderer
    participant RP as Tiled Render Product
    participant Annotator
    Camera->>Renderer: create_render_data(spec)
    Renderer->>RP: "create(name=data_types)"
    Renderer->>Annotator: attach([rp.path])
    Camera->>Renderer: render/read outputs
    Camera->>Renderer: cleanup(render_data)
    Renderer->>Annotator: detach([rp.path])
    Renderer->>RP: destroy()
    Renderer->>Renderer: clear retained state

Loading

_{Reviews (2): Last reviewed commit: "Merge branch 'develop' into remove-deins..." | Re-trigger Greptile}

[isaaclab-review-bot]

Isaac Lab Review Bot

Summary

This PR removes the NVBUG#6418121 USD-instancing workaround from the shared rendering test helpers: the _maybe_disable_instancing_for_current_stage helper and its two call sites in rendering_test_franka_cloth / rendering_test_franka_soft are deleted, along with the isaacsim_rtx_renderer + motion_vectors skip in the soft-body test. A .skip changelog fragment is added under source/isaaclab_tasks/changelog.d/, which is the correct tier for a test-only change. The deletion is self-consistent — no remaining references to the removed helper appear in the modified file, and no runtime/public API is touched. The main open question is baseline coverage: the removal both re-enables a previously skipped parameterization and changes the stage state (instance proxies now retained) under which the existing golden images and golden stages were captured.

Architecture impact

None. The change is confined to test utilities in source/isaaclab_tasks/test/ and removes a temporary workaround; no public API, config schema, or runtime behavior is affected.

Test coverage

No new assertions are added; coverage changes by re-enabling previously skipped isaacsim_rtx_renderer + motion_vectors cases in rendering_test_franka_soft. Since validate_camera_outputs bootstraps and then fails when a golden image is missing, and maybe_save_stage compares prim structure exactly, the PR should state which parameterized runs were executed to confirm existing and newly enabled baselines still pass with instancing enabled.

Implementation verdict

Minor fixes needed. Posted 1 actionable finding inline.

The PR exceeded the automated context budget, so some file content was truncated.

Automated comment-only review; human maintainers own approval decisions.

[rilei-nvidia]

Had a minor comment, Piotr covered most of them. Preemptive LGTM