Fix GelSight Mini render data path - #6777
Conversation
Point the predefined configuration at the available R1.5 render data so background and calibration downloads no longer return 404.
There was a problem hiding this comment.
Isaac Lab Review Bot
No material issues were identified in the reviewed diff.
- Design and architecture: No material concerns.
- API: No material concerns.
- Implementation: No material concerns.
Ship it. No actionable findings were identified in the reviewed diff.
Conservative automated review; human maintainers own approval decisions.
| assert f"{GELSIGHT_MINI_CFG.sensor_data_dir_name}/{GELSIGHT_MINI_CFG.background_path}" == ( | ||
| "gelsight_r15_data/bg.jpg" | ||
| ) |
There was a problem hiding this comment.
This assertion only restates the configured path string, so it remains green when the referenced resource cannot be resolved or used during GelSight renderer initialization. Exercise resource resolution or renderer initialization to cover the reported regression.
Knowledge Base Used: Isaac Lab Assets and Contrib Extensions
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Greptile SummaryCorrects the GelSight Mini render-data directory and adds regression coverage.
Confidence Score: 4/5The PR appears safe to merge, with the non-blocking caveat that its regression test does not verify the resource-resolution failure it is intended to prevent. The configuration now references the intended published directory, but the test can pass without proving that the background is retrievable and usable by the renderer. Files Needing Attention: source/isaaclab_assets/test/test_gelsight.py Important Files Changed
Reviews (1): Last reviewed commit: "Fix GelSight Mini render data path" | Re-trigger Greptile |
Description
Point
GELSIGHT_MINI_CFGat the publishedgelsight_r15_datarender-datadirectory. The previous
gs_mini_databackground and calibration URLs return404, causing GelSight Mini renderer initialization to fail with
FileNotFoundError.This change preserves the existing public configuration symbol and makes its
background resolve to:
IsaacLab/TacSL/gelsight_r15_data/bg.jpgNo new dependencies are required.
Fixes #6182
Type of change
Screenshots
Not applicable.
Validation
gs_mini_data/bg.jpgpath.isaaclab.bat -p -m pytest source/isaaclab_assets/test/test_gelsight.py -q(
1 passed; one unrelated existing deprecation warning)isaaclab.bat -p tools/changelog/cli.py check developisaaclab.bat -fChecklist
isaaclab.bat -f.isaaclab_assets.CONTRIBUTORS.md.