[Cleanup] Remove unused directory and alias functions - #6988
Conversation
Greptile SummaryRemoves unused physics and renderer capability methods and deletes empty video-recording packages.
Confidence Score: 5/5The PR appears safe to merge because the removed methods and packages have no remaining repository callers, imports, or registration dependencies. The removals are applied consistently across base classes and backend overrides, while targeted checks found no reachable in-repository use of the deleted APIs or package paths. Important Files Changed
Reviews (1): Last reviewed commit: "Remove unused directory and functions" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
This PR removes two public capability classmethods and their backend overrides, plus two empty video-recording packages. The capability methods are deleted without the prior deprecation required by repository policy.
- Design and architecture: Removing the capability-probe layer is internally consistent because the base methods and all shown backend overrides are removed together. However, architectural cleanup does not bypass the compatibility policy for public base-class extension points.
- API:
PhysicsManager.provides_implicit_dampingandBaseRenderer.provides_temporal_camera_dataare documented public classmethods that external backends may call or override. They must be deprecated for a release before removal; the changelog’s major bump and migration note do not replace that deprecation period. - Implementation: The method deletions are localized and corresponding in-tree overrides are removed. Restore the base-class methods with deprecation warnings, classify the current changelog entry as
Deprecated, and defer deletion until a later release.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
| Removed | ||
| ^^^^^^^ | ||
|
|
||
| * Removed the unused ``PhysicsManager.provides_implicit_damping`` and |
There was a problem hiding this comment.
🟡 Warning · Api — Public capability methods removed without prior deprecation
PhysicsManager.provides_implicit_damping and BaseRenderer.provides_temporal_camera_data are public, documented classmethods on base classes that out-of-tree physics backends and renderers can override or call; both are deleted outright here. Repository guidelines require deprecating public API symbols in a prior release before removal. Keep the base-class implementations with a deprecation warning and file this fragment under Deprecated, then delete them in a later release.
Description
Remove unused functions and empty video recording submodule
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there