Fix OVPhysX contact force history reset - #7208
Conversation
Greptile SummaryThe PR fixes OVPhysX contact-sensor resets so filtered force-matrix history is cleared only for selected environments.
Confidence Score: 5/5The PR appears safe to merge, with the reset behavior correctly scoped to selected environments. The new loop uses dimensions consistent with the allocated history buffer, safely handles configurations without filtered-force buffers, and has focused regression coverage for masked resets. Important Files Changed
Reviews (1): Last reviewed commit: "Fix OVPhysX contact force history reset" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The reset path now passes filtered force-matrix history into the existing Warp kernel, clears it only for masked environments, and includes a focused CPU regression test plus changelog fragment.
- Design and architecture: Using the existing reset kernel keeps history cleanup aligned with the other contact-sensor buffers and preserves unselected environments through the established env-mask early return.
- API: The positional kernel signature and the shown ContactSensor.reset launch site remain aligned. No public sensor property, configuration field, or exported symbol is changed; only reset semantics for force_matrix_w_history are corrected.
- Implementation: The added indexing matches the documented buffer layout, and the test verifies both clearing a selected environment and preserving an unselected one. The test directly exercises the kernel rather than the complete ContactSensor.reset integration path, leaving a small non-blocking integration-coverage tradeoff.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
## Description Bundled backport to `release/3.0.0` to reduce CI load. Source PRs reviewed for this bundle: - #7020 — already represented in `release/3.0.0`; its cherry-pick was empty, so no duplicate commit was added. - #7207 - #7229 - #7227 - #7231 - #6762 - #7208 - #7168 — backports the current PR head while the source PR is still open. - #7157 - #7216 ## Type of change - Bug fix - Documentation update - Workflow / packaging update ## Checklist - [x] I have read and understood the contribution guidelines. - [x] I have run formatting checks. - [x] Documentation changes are included. - [x] Documentation build generates no new warnings. - [x] Focused regression coverage passed. - [x] Required changelog fragments are included by the source PRs. - [x] Contributors are already listed or included by the source PRs. --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Mustafa H <34825877+StafaH@users.noreply.github.com> Co-authored-by: Richard Lei <rilei@nvidia.com> Co-authored-by: Mustafa Haiderbhai <mhaiderbhai@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Summary
Testing
uv run --extra test python -m pytest source/isaaclab_ov/test/sensors/test_contact_sensor_kernels.pyuv run python tools/changelog/cli.py check developuv run isaaclab -f