Fix AppLauncher tests: update newton alias and remove legacy headless CLI test - #7533
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
This test-only change updates visualizer cases from the deprecated newton alias to newton_gl and removes one legacy combined headless/visualizer test. No production behavior is modified.
- Design and architecture: The parsing, Hydra passthrough, and headless-resolution test paths remain aligned with the current visualizer naming. The change does not alter
AppLauncherarchitecture or responsibility boundaries. - API: No public or extension-facing API is changed. Existing
AppLauncherparsing and resolution methods are exercised with updated test inputs but are not redefined. - Implementation: The changed assertions consistently match the updated
newton_glinputs. Removing the combined deprecated-headless/visualizer case reduces coverage of that specific interaction, but the retained deprecated-headless precedence test continues to cover the legacy argument path, and the patch supplies no evidence that the removed combination remains supported.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryUpdates AppLauncher tests to use the canonical
Confidence Score: 5/5The PR appears safe to merge because the test updates match the current AppLauncher visualizer contract and introduce no production behavior changes. The canonical Important Files Changed
Reviews (1): Last reviewed commit: "Fix AppLauncher tests: update newton ali..." | Re-trigger Greptile |
bf16c94 to
799d709
Compare
|
run-ci |
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
|
run-ci |
|
Backported to |
… CLI test (#7533) This PR isolates and fixes the failing tests in `test_kwarg_launch.py` that surfaced during the investigation of #7403 (and the closed PR #7444). When run on a clean `upstream/develop`, `test_kwarg_launch.py` fails on exactly four tests. This PR addresses them: 1. **Newton Alias Fallout:** Fixed three tests (`test_parse_visualizer_csv_accepts_comma_delimited_values`, `test_visualizer_csv_does_not_swallow_hydra_overrides`, and `test_matrix_cli_kit_newton_with_custom_kit_cfg_intent_non_headless`) which were failing because they asserted against the deprecated `newton` alias instead of `newton_gl`. The third test was explicitly renamed to `test_matrix_cli_kit_newton_gl_with_custom_kit_cfg_intent_non_headless` to reflect the updated assertion. 2. **Removed Dead CLI Path:** Deleted `test_matrix_headless_with_viz_names_takes_precedence`. This test was failing because it passed `headless=True` directly through `_resolve_visualizer_settings`, simulating the `--headless` CLI flag which was removed in 3.0 and is no longer supported upstream. 3. **Hygiene Updates (Not Failing):** - Replaced `"kit, newton"` with `"kit, newton_gl"` in `test_parse_visualizer_csv_rejects_spaces_between_entries`. This test successfully raises an `ArgumentTypeError` before checking aliases so it wasn't failing, but it was updated to prevent stale strings from persisting. - Renamed `test_matrix_no_cli_with_cfg_kit_newton_non_headless` to `test_matrix_no_cli_with_cfg_kit_newton_gl_non_headless` for naming consistency. This test also passed previously but carried the stale alias in its name. _See the attached `pytest_before_fix.txt` (showing the 4 failures on develop) and `pytest_after_fix.txt` (showing 47 clean passes) for the exact run logs._ [pytest_after_fix.txt](https://github.com/user-attachments/files/31785416/pytest_after_fix.txt) [pytest_before_fix.txt](https://github.com/user-attachments/files/31785426/pytest_before_fix.txt) ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com> (cherry picked from commit cb43dd0)
This PR isolates and fixes the failing tests in
test_kwarg_launch.pythat surfaced during the investigation of #7403 (and the closed PR #7444).When run on a clean
upstream/develop,test_kwarg_launch.pyfails on exactly four tests. This PR addresses them:test_parse_visualizer_csv_accepts_comma_delimited_values,test_visualizer_csv_does_not_swallow_hydra_overrides, andtest_matrix_cli_kit_newton_with_custom_kit_cfg_intent_non_headless) which were failing because they asserted against the deprecatednewtonalias instead ofnewton_gl. The third test was explicitly renamed totest_matrix_cli_kit_newton_gl_with_custom_kit_cfg_intent_non_headlessto reflect the updated assertion.test_matrix_headless_with_viz_names_takes_precedence. This test was failing because it passedheadless=Truedirectly through_resolve_visualizer_settings, simulating the--headlessCLI flag which was removed in 3.0 and is no longer supported upstream."kit, newton"with"kit, newton_gl"intest_parse_visualizer_csv_rejects_spaces_between_entries. This test successfully raises anArgumentTypeErrorbefore checking aliases so it wasn't failing, but it was updated to prevent stale strings from persisting.test_matrix_no_cli_with_cfg_kit_newton_non_headlesstotest_matrix_no_cli_with_cfg_kit_newton_gl_non_headlessfor naming consistency. This test also passed previously but carried the stale alias in its name.See the attached
pytest_before_fix.txt(showing the 4 failures on develop) andpytest_after_fix.txt(showing 47 clean passes) for the exact run logs.pytest_after_fix.txt
pytest_before_fix.txt
Release backport
develop