Fix RLinf uv runtime environment upload - #7568
Conversation
github-actions
Bot
added
bug
![isaaclab-review-bot[bot]](https://avatars.githubusercontent.com/u/157846462?s=60&v=4){kind=small}
There was a problem hiding this comment.
Isaac Lab Review Bot
The RLinf entrypoint now disables Ray's automatic uv runtime-environment upload while preserving explicit user configuration via setdefault. The user-visible startup fix is missing the required isaaclab_rl changelog fragment.
- Design and architecture: Keeping the Ray-specific environment toggle in the RLinf entrypoint contains the workaround at the relevant integration boundary and follows the existing environment-based configuration pattern.
- API: No CLI arguments, public symbols, or return types change. An explicitly supplied
RAY_ENABLE_UV_RUN_RUNTIME_ENVvalue remains honored. - Implementation: The environment variable is set before the lazy RLinf imports and training initialization. Add a past-tense bug-fix fragment under
source/isaaclab_rl/changelog.d/as required for this user-visible package change.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
| # checkpoints, which exceed Ray's 500 MiB upload limit. RLinf already | ||
| # selects the Python executable for each worker, so this upload is neither | ||
| # needed nor desirable. | ||
| os.environ.setdefault("RAY_ENABLE_UV_RUN_RUNTIME_ENV", "0") |
There was a problem hiding this comment.
🟡 Warning · Implementation — Missing isaaclab_rl changelog fragment
This PR changes user-visible RLinf launch behavior in source/isaaclab_rl but includes no fragment under source/isaaclab_rl/changelog.d/. Repository rules require one fragment per changed source package (a .skip fragment when no release note is needed), so this fix would be dropped from generated release notes. Add a past-tense bug-fix fragment describing the disabled automatic Ray uv runtime-environment upload; do not edit CHANGELOG.rst or extension.toml.
Greptile SummaryThis PR disables Ray’s automatic uv runtime environment for RLinf training, preventing oversized Isaac Lab working-directory uploads.
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The new environment default is applied before RLinf and Ray initialization on the supported launch paths, preventing the unwanted upload while allowing an explicit user override. Important Files Changed
Reviews (1): Last reviewed commit: "Fix RLinf uv runtime environment upload" | Re-trigger Greptile |
|
run-ci |
isaaclab-bot
Bot
added
ci:run-docker
|
Backported to |
# Description Disable Ray's automatic uv runtime environment for RLinf training to avoid exceeding the 512 MB working directory upload limit. <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html 💡 Please try to keep PRs small and focused. Large PRs are harder to review and merge. --> Fixes # (issue) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (existing functionality will not work without user modification) - Documentation update ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist Docker and GPU tests run on demand. Push the commits you want tested, then comment `run-ci` on the pull request. - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> (cherry picked from commit 23c6a68)
3 participants
Description
Disable Ray's automatic uv runtime environment for RLinf training to avoid exceeding the 512 MB working directory upload limit.
Fixes # (issue)
Type of change
Release backport
developScreenshots
Please attach before and after screenshots of the change if applicable.
Checklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there